Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue:4753] Add encryption docs to Functions develop #5781

Conversation

wolfstudy
Copy link
Member

Signed-off-by: xiaolong.ran rxl@apache.org

Fixes #4753

Motivation

The encryption section in the Functions develop chapter is missing.

Modifications

  • Add encryption docs to Functions develop

Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy wolfstudy self-assigned this Dec 2, 2019
@wolfstudy wolfstudy added this to the 2.5.0 milestone Dec 2, 2019
@wolfstudy wolfstudy added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. area/function labels Dec 2, 2019
@wolfstudy
Copy link
Member Author

@sijie @jennifer88huang PTAL, thanks.

Copy link
Contributor

@Jennifer88huang-zz Jennifer88huang-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the security mechanism for Pulsar Functions is the same with that in Pulsar Functions worker, it's ok to add link here.

@Jennifer88huang-zz
Copy link
Contributor

run integration tests
run java8 tests

@wolfstudy
Copy link
Member Author

run java8 tests

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's what the original github issue asks for. The original issue asks for the documentation around security especially secrets (https://github.com/apache/pulsar/tree/master/pulsar-functions/secrets) in the development of functions. It is not about security in the function worker.

@wolfstudy
Copy link
Member Author

I don't think that's what the original github issue asks for. The original issue asks for the documentation around security especially secrets (https://github.com/apache/pulsar/tree/master/pulsar-functions/secrets) in the development of functions. It is not about security in the function worker.

Thanks @sijie clarification, will fix it.

Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
Copy link
Member Author

wolfstudy commented Dec 9, 2019

@sijie @jennifer88huang PTAL again, thanks.

@wolfstudy
Copy link
Member Author

run java8 tests

@wolfstudy
Copy link
Member Author

org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryChangeLedgerPathTest.setUp

run java8 tests

@Jennifer88huang-zz Jennifer88huang-zz merged commit 8a20d9a into apache:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Add documentation for Functions develop: encryption
3 participants