Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5825: make PulsarClusterMetadataSetup idempotent #5879

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Fix #5825: make PulsarClusterMetadataSetup idempotent #5879

merged 1 commit into from
Dec 20, 2019

Conversation

jiazhai
Copy link
Member

@jiazhai jiazhai commented Dec 17, 2019

Fixes #5825

Motivation

PulsarClusterMetadataSetup runs on the second time will failed because some zk nodes already exists. This change will fix this issue.

Modifications

  • catch and ignore exception for exists zk nodes.
  • add test for it.

@jiazhai jiazhai self-assigned this Dec 17, 2019
@codelipenghui
Copy link
Contributor

run java8 tests

@jiazhai
Copy link
Member Author

jiazhai commented Dec 18, 2019

run java8 tests

1 similar comment
@jiazhai
Copy link
Member Author

jiazhai commented Dec 18, 2019

run java8 tests

@sijie sijie added area/cli type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Dec 20, 2019
@sijie sijie added this to the 2.5.0 milestone Dec 20, 2019
@sijie sijie merged commit a958098 into apache:master Dec 20, 2019
@jiazhai jiazhai mentioned this pull request Dec 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murong00 murong00 murong00 left review comments

@sijie sijie sijie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@jiazhai jiazhai

Labels
area/cli type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Improve PulsarClusterMetadataSetup to make it idempotent
4 participants
@jiazhai @codelipenghui @sijie @murong00