-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 5920][pulsar-io] Adds integration test for RabbitMQ. #6033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
Jan 12, 2020
@tuteng Would you please help review this? |
sijie
approved these changes
Jan 13, 2020
run java8 tests |
sijie
approved these changes
Jan 13, 2020
Add label release/2.5.1 |
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
Fixes #5920 ### Motivation The current RabbitMQ connector lacks an integration test. ### Modifications Adds an integration test for the RabbitMQ connector(both source and sink): - A container definition using `rabbitmq:3.8-management` as suggested. - A RabbitMQ source tester, which provides configurations for the RabbitMQ source connector and publishes messages to the RabbitMQ. - A RabbitMQ sink tester, which provides configurations for the RabbitMQ sink connector and consumes messages from the RabbitMQ for verification. - A test case that invokes the testers with the current test framework. ### Verifying this change This change added tests and can be verified as follows: *(example:)* - *Added integration tests for the RabbitMQ connector* (cherry picked from commit 4cfb952)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
Fixes apache#5920 ### Motivation The current RabbitMQ connector lacks an integration test. ### Modifications Adds an integration test for the RabbitMQ connector(both source and sink): - A container definition using `rabbitmq:3.8-management` as suggested. - A RabbitMQ source tester, which provides configurations for the RabbitMQ source connector and publishes messages to the RabbitMQ. - A RabbitMQ sink tester, which provides configurations for the RabbitMQ sink connector and consumes messages from the RabbitMQ for verification. - A test case that invokes the testers with the current test framework. ### Verifying this change This change added tests and can be verified as follows: *(example:)* - *Added integration tests for the RabbitMQ connector* (cherry picked from commit 4cfb952)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#5920 ### Motivation The current RabbitMQ connector lacks an integration test. ### Modifications Adds an integration test for the RabbitMQ connector(both source and sink): - A container definition using `rabbitmq:3.8-management` as suggested. - A RabbitMQ source tester, which provides configurations for the RabbitMQ source connector and publishes messages to the RabbitMQ. - A RabbitMQ sink tester, which provides configurations for the RabbitMQ sink connector and consumes messages from the RabbitMQ for verification. - A test case that invokes the testers with the current test framework. ### Verifying this change This change added tests and can be verified as follows: *(example:)* - *Added integration tests for the RabbitMQ connector*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5920
Motivation
The current RabbitMQ connector lacks an integration test.
Modifications
Adds an integration test for the RabbitMQ connector(both source and sink):
rabbitmq:3.8-management
as suggested.Verifying this change
This change added tests and can be verified as follows:
(example:)