[Issue 6173][compaction] Fix log compaction for flow control/empty topic/last deletion #6237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
added
area/compaction
release/2.4.3
release/2.5.1
type/bug
codelipenghui
approved these changes
Feb 7, 2020
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Feb 23, 2020
…pic/last deletion (apache#6237) Fixes apache#6173 ### Motivation Fixes problems for log compaction found in issue apache#6173 : 1. Compaction fails for an empty topic. 2. Compaction never ends if the value of the last message is an empty batch message when the compaction is triggered. 3. Compaction fails for a topic with batch messages because RawReader flow control doesn't handle batch messages properly. ### Modifications 1. Check if any message is available before compaction phases, and finish the compaction immediately if there is no messages to read to avoid timeout exception. 2. Add missing check for empty batch message for the condition to end the phase 2 loop. 3. Increase correct number of available permits in RawConsumer for batch messages. ### Verifying this change Producing messages in both batch and not-batch mode in corresponding tests.
tuteng
pushed a commit
to AmateurEvents/pulsar
that referenced
this pull request
Mar 21, 2020
…pic/last deletion (apache#6237) Fixes apache#6173 ### Motivation Fixes problems for log compaction found in issue apache#6173 : 1. Compaction fails for an empty topic. 2. Compaction never ends if the value of the last message is an empty batch message when the compaction is triggered. 3. Compaction fails for a topic with batch messages because RawReader flow control doesn't handle batch messages properly. ### Modifications 1. Check if any message is available before compaction phases, and finish the compaction immediately if there is no messages to read to avoid timeout exception. 2. Add missing check for empty batch message for the condition to end the phase 2 loop. 3. Increase correct number of available permits in RawConsumer for batch messages. ### Verifying this change Producing messages in both batch and not-batch mode in corresponding tests. (cherry picked from commit d3f6c55)
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
…pic/last deletion (#6237) Fixes #6173 ### Motivation Fixes problems for log compaction found in issue #6173 : 1. Compaction fails for an empty topic. 2. Compaction never ends if the value of the last message is an empty batch message when the compaction is triggered. 3. Compaction fails for a topic with batch messages because RawReader flow control doesn't handle batch messages properly. ### Modifications 1. Check if any message is available before compaction phases, and finish the compaction immediately if there is no messages to read to avoid timeout exception. 2. Add missing check for empty batch message for the condition to end the phase 2 loop. 3. Increase correct number of available permits in RawConsumer for batch messages. ### Verifying this change Producing messages in both batch and not-batch mode in corresponding tests. (cherry picked from commit d3f6c55)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
…pic/last deletion (apache#6237) Fixes apache#6173 ### Motivation Fixes problems for log compaction found in issue apache#6173 : 1. Compaction fails for an empty topic. 2. Compaction never ends if the value of the last message is an empty batch message when the compaction is triggered. 3. Compaction fails for a topic with batch messages because RawReader flow control doesn't handle batch messages properly. ### Modifications 1. Check if any message is available before compaction phases, and finish the compaction immediately if there is no messages to read to avoid timeout exception. 2. Add missing check for empty batch message for the condition to end the phase 2 loop. 3. Increase correct number of available permits in RawConsumer for batch messages. ### Verifying this change Producing messages in both batch and not-batch mode in corresponding tests. (cherry picked from commit d3f6c55)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…pic/last deletion (apache#6237) Fixes apache#6173 ### Motivation Fixes problems for log compaction found in issue apache#6173 : 1. Compaction fails for an empty topic. 2. Compaction never ends if the value of the last message is an empty batch message when the compaction is triggered. 3. Compaction fails for a topic with batch messages because RawReader flow control doesn't handle batch messages properly. ### Modifications 1. Check if any message is available before compaction phases, and finish the compaction immediately if there is no messages to read to avoid timeout exception. 2. Add missing check for empty batch message for the condition to end the phase 2 loop. 3. Increase correct number of available permits in RawConsumer for batch messages. ### Verifying this change Producing messages in both batch and not-batch mode in corresponding tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6173
Motivation
Fixes problems for log compaction found in issue #6173 :
Modifications
Verifying this change
Producing messages in both batch and not-batch mode in corresponding tests.