Implementation of Transaction Buffer Client. #6544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
force-pushed
the
txn_buffer_client
branch
from
a4fc1f6
to
b318862
Compare
codelipenghui
changed the title
congbobo184
reviewed
Mar 23, 2020
| } else { | ||
| long diff = (peeked.createdAt + operationTimeoutInMills) - System.currentTimeMillis(); | ||
| if (diff <= 0) { | ||
| timeToWaitMs = operationTimeoutInMills; |
There was a problem hiding this comment.
It is time out, so timeTowaitMs shouldn't = operationTimeoutInMills
| cnx(topic).whenComplete((clientCnx, throwable) -> { | ||
| if (throwable == null) { | ||
| try { | ||
| clientCnx.ctx().writeAndFlush(cmd, clientCnx.ctx().voidPromise()); |
There was a problem hiding this comment.
I think clientCnx.ctx().writeAndFlush(cmd, clientCnx.ctx().voidPromise()); should .addListener
codelipenghui
force-pushed
the
txn_buffer_client
branch
from
5d7e816
to
f9c9910
Compare
sijie
approved these changes
Jul 21, 2020
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jul 21, 2020
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
5 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
50 tasks
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Implementation of Transaction Buffer Client. * Fix check style. * add license header * fix tests
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
* Implementation of Transaction Buffer Client. * Fix check style. * add license header * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement the transaction buffer client.
Modifications
Verifying this change
New unit tests added
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation