Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not retry on authorization failure #6577

Merged
merged 6 commits into from
Mar 22, 2020

Conversation

srkukarni
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

If the client does not have the right authorization, we should not retry the request.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label Mar 20, 2020
@merlimat merlimat added this to the 2.6.0 milestone Mar 20, 2020
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@srkukarni srkukarni merged commit 6cb0d25 into apache:master Mar 22, 2020
@srkukarni srkukarni deleted the backoff_on_authfailure branch March 22, 2020 00:23
tuteng pushed a commit that referenced this pull request Apr 13, 2020
* Do not retry on authorization failure

* Address feedback

* Fix logic

* Fix test

* Fixed more tests

* Fixed more test

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
(cherry picked from commit 6cb0d25)
jiazhai pushed a commit to jiazhai/pulsar that referenced this pull request May 18, 2020
* Do not retry on authorization failure

* Address feedback

* Fix logic

* Fix test

* Fixed more tests

* Fixed more test

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>(cherry picked from commit 6cb0d25)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
* Do not retry on authorization failure

* Address feedback

* Fix logic

* Fix test

* Fixed more tests

* Fixed more test

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2.5.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants