[hotfix]Python function protobuf missing field and broker test failed #6641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuteng
added
type/bug
jiazhai
approved these changes
Mar 31, 2020
codelipenghui
approved these changes
Mar 31, 2020
|
/pulsarbot run-failure-checks |
tuteng
force-pushed
the
fix/protobuf-missing-field1
branch
from
198cad5
to
f307b1d
Compare
(cherry picked from commit 5458e60)
tuteng
changed the title
|
@tuteng great work! |
|
Add label release/2.5.2 |
jiazhai
pushed a commit
that referenced
this pull request
May 8, 2020
…#6641) At present, in the test, we found that due to the addition of a field `forwardSourceMessageProperty` in the proto file of function, this field was lost in the proto file generated by python and go. Due to python parsing with the following code: ``` json_format.Parse(args.function_details, function_details) ``` the following exception will be thrown. ``` 2020-03-30T13:13:25.2339031Z 13:13:24.379 [pulsar-external-listener-20-1] INFO org.apache.pulsar.functions.runtime.process.ProcessRuntime - Started process successfully 2020-03-30T13:13:25.2339190Z Traceback (most recent call last): 2020-03-30T13:13:25.2340782Z File "/pulsar/instances/python-instance/python_instance_main.py", line 211, in <module> 2020-03-30T13:13:25.2340944Z main() 2020-03-30T13:13:25.2342589Z File "/pulsar/instances/python-instance/python_instance_main.py", line 98, in main 2020-03-30T13:13:25.2342744Z json_format.Parse(args.function_details, function_details) 2020-03-30T13:13:25.2354119Z File "/usr/local/lib/python2.7/dist-packages/google/protobuf/json_format.py", line 430, in Parse 2020-03-30T13:13:25.2354284Z return ParseDict(js, message, ignore_unknown_fields, descriptor_pool) 2020-03-30T13:13:25.2354689Z File "/usr/local/lib/python2.7/dist-packages/google/protobuf/json_format.py", line 450, in ParseDict 2020-03-30T13:13:25.2354882Z parser.ConvertMessage(js_dict, message) 2020-03-30T13:13:25.2355386Z File "/usr/local/lib/python2.7/dist-packages/google/protobuf/json_format.py", line 481, in ConvertMessage 2020-03-30T13:13:25.2355537Z self._ConvertFieldValuePair(value, message) 2020-03-30T13:13:25.2356082Z File "/usr/local/lib/python2.7/dist-packages/google/protobuf/json_format.py", line 590, in _ConvertFieldValuePair 2020-03-30T13:13:25.2356559Z raise ParseError('Failed to parse {0} field: {1}.'.format(name, e)) 2020-03-30T13:13:25.2357199Z google.protobuf.json_format.ParseError: Failed to parse sink field: Message type "proto.SinkSpec" has no field named "forwardSourceMessageProperty". 2020-03-30T13:13:25.2357634Z Available Fields(except extensions): ['className', 'configs', 'typeClassName', 'topic', 'serDeClassName', 'builtin', 'schemaType']. ``` This pr is mainly to fix the proto file generated by python first. In order to make the test pass smoothly, I will gradually fix this problem in other languages in the next pull request. * Enable build docker image to pulsar and pulsar-all. * Add new generated protobuf file for python * Disable go function integration test * Add sleep for method testGetPartitionedStatsInternal The integration process test passed AmateurEvents#22 (cherry picked from commit c955ff9)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…apache#6641) ### Motivation At present, in the test, we found that due to the addition of a field `forwardSourceMessageProperty` in the proto file of function, this field was lost in the proto file generated by python and go. Due to python parsing with the following code: ``` json_format.Parse(args.function_details, function_details) ``` the following exception will be thrown. ``` 2020-03-30T13:13:25.2339031Z 13:13:24.379 [pulsar-external-listener-20-1] INFO org.apache.pulsar.functions.runtime.process.ProcessRuntime - Started process successfully 2020-03-30T13:13:25.2339190Z Traceback (most recent call last): 2020-03-30T13:13:25.2340782Z File "/pulsar/instances/python-instance/python_instance_main.py", line 211, in <module> 2020-03-30T13:13:25.2340944Z main() 2020-03-30T13:13:25.2342589Z File "/pulsar/instances/python-instance/python_instance_main.py", line 98, in main 2020-03-30T13:13:25.2342744Z json_format.Parse(args.function_details, function_details) 2020-03-30T13:13:25.2354119Z File "/usr/local/lib/python2.7/dist-packages/google/protobuf/json_format.py", line 430, in Parse 2020-03-30T13:13:25.2354284Z return ParseDict(js, message, ignore_unknown_fields, descriptor_pool) 2020-03-30T13:13:25.2354689Z File "/usr/local/lib/python2.7/dist-packages/google/protobuf/json_format.py", line 450, in ParseDict 2020-03-30T13:13:25.2354882Z parser.ConvertMessage(js_dict, message) 2020-03-30T13:13:25.2355386Z File "/usr/local/lib/python2.7/dist-packages/google/protobuf/json_format.py", line 481, in ConvertMessage 2020-03-30T13:13:25.2355537Z self._ConvertFieldValuePair(value, message) 2020-03-30T13:13:25.2356082Z File "/usr/local/lib/python2.7/dist-packages/google/protobuf/json_format.py", line 590, in _ConvertFieldValuePair 2020-03-30T13:13:25.2356559Z raise ParseError('Failed to parse {0} field: {1}.'.format(name, e)) 2020-03-30T13:13:25.2357199Z google.protobuf.json_format.ParseError: Failed to parse sink field: Message type "proto.SinkSpec" has no field named "forwardSourceMessageProperty". 2020-03-30T13:13:25.2357634Z Available Fields(except extensions): ['className', 'configs', 'typeClassName', 'topic', 'serDeClassName', 'builtin', 'schemaType']. ``` This pr is mainly to fix the proto file generated by python first. In order to make the test pass smoothly, I will gradually fix this problem in other languages in the next pull request. ### Modifications * Enable build docker image to pulsar and pulsar-all. * Add new generated protobuf file for python * Disable go function integration test * Add sleep for method testGetPartitionedStatsInternal ### Verifying this change The integration process test passed AmateurEvents#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At present, in the test, we found that due to the addition of a field
forwardSourceMessagePropertyin the proto file of function, this field was lost in the proto file generated by python and go. Due to python parsing with the following code:the following exception will be thrown.
This pr is mainly to fix the proto file generated by python first. In order to make the test pass smoothly, I will gradually fix this problem in other languages in the next pull request.
Modifications
Verifying this change
The integration process test passed AmateurEvents#22