[Pulsar Functions] Support config admin CLI in funtions runtime #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolong.ran <rxl@apache.org>
wolfstudy
requested review from
jerrypeng,
srkukarni,
codelipenghui,
jiazhai and
sijie
wolfstudy
changed the title
wolfstudy
changed the title
codelipenghui
approved these changes
Apr 7, 2020
Comment on lines
+163
to
+164
| ## Config admin CLI | ||
| #configAdminCLI: |
jiazhai
approved these changes
Apr 7, 2020
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Apr 8, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Signed-off-by: xiaolong.ran <rxl@apache.org> ### Motivation Sometimes, users want to use a customized admin CLI tool. Currently, in the k8s runtime, hardcode is used in `getdownloadcommands()`. This change will support users to configure the CLI tool they want. The default value is: `/bin/pulsar-admin`. ### Modifications - Support config admin CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran rxl@apache.org
Motivation
Sometimes, users want to use a customized admin CLI tool. Currently, in the k8s runtime, hardcode is used in
getdownloadcommands(). This change will support users to configure the CLI tool they want. The default value is:/bin/pulsar-admin.Modifications