Improve backlogSize stats in the topic. #6700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
added
the
type/enhancement
sijie
approved these changes
Apr 9, 2020
merlimat
reviewed
Apr 9, 2020
| Thread.sleep(1000); | ||
|
|
||
| TopicStats topicStats = admin.topics().getStats(topic); | ||
| System.out.println(topicStats.backlogSize); |
There was a problem hiding this comment.
The test should assert here instead of printing. Also make sure it's more robust against race conditions
|
/pulsarbot run-failure-checks |
codelipenghui
force-pushed
the
fix_backlog_size
branch
from
2b522e2
to
f142726
Compare
|
/pulsarbot run-failure-checks |
|
Add label release/2.5.1 and remove label release/2.5.2 |
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
### Motivation When all subscriptions have no backlogs, but the backlog size of the topic stats is not 0. So this PR improves the backlog size calculation of the managed ledger. ### Modifications If all entries are consumed, return the ledger size as the consumed size. ### Verifying this change A new unit test added. (cherry picked from commit d72e383)
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
### Motivation When all subscriptions have no backlogs, but the backlog size of the topic stats is not 0. So this PR improves the backlog size calculation of the managed ledger. ### Modifications If all entries are consumed, return the ledger size as the consumed size. ### Verifying this change A new unit test added. (cherry picked from commit d72e383)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation When all subscriptions have no backlogs, but the backlog size of the topic stats is not 0. So this PR improves the backlog size calculation of the managed ledger. ### Modifications If all entries are consumed, return the ledger size as the consumed size. ### Verifying this change A new unit test added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When all subscriptions have no backlogs, but the backlog size of the topic stats is not 0. So this PR improves the backlog size calculation of the managed ledger.
Modifications
If all entries are consumed, return the ledger size as the consumed size.
Verifying this change
A new unit test added.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation