expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus #6705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Apr 11, 2020
| @@ -20,10 +20,14 @@ | |||
|
|
|||
| import java.io.IOException; | |||
| import java.io.OutputStream; | |||
| import java.util.Enumeration; | |||
| import java.util.*; | |||
There was a problem hiding this comment.
@hangc0276 can we avoid wildcard import?
There was a problem hiding this comment.
ok，i will update in next commit with metric document.
sijie
added
component/stats
doc-required
codelipenghui
approved these changes
Apr 13, 2020
|
@hangc0276 You'd better rebase the branch with master since there are some fixes related to integration tests. |
hangc0276
force-pushed
the
expose_metric
branch
from
5f58876
to
68381c9
Compare
|
I have updated the document and rebase the master branch, but it still run test case failed. Please help take a look @codelipenghui @sijie |
aahmed-se
approved these changes
Apr 19, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
@hangc0276 Could you please rebase the branch? |
hangc0276
force-pushed
the
expose_metric
branch
from
68381c9
to
81c2a79
Compare
I have rebase the master branch. |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
removed
the
doc-required
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
May 5, 2020
…etheus (apache#6705) ## Motivation The managed ledger read cache monitor metric is export via /admin/broker-stats/metrics with json format, it is hard to parse, collect and display, what's more the read cache is a very import module for message consuming throughput and latency. So collect and display the read cache metrics is extremely urgent for pulsar in production. ## Changes I parse the json format metric to prometheus message type and export to prometheus monitor port, so those metrics can be displayed in grafana. Please help check those changes, if it's ok, i will update the metric document.
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
May 5, 2020
…etheus (apache#6705) ## Motivation The managed ledger read cache monitor metric is export via /admin/broker-stats/metrics with json format, it is hard to parse, collect and display, what's more the read cache is a very import module for message consuming throughput and latency. So collect and display the read cache metrics is extremely urgent for pulsar in production. ## Changes I parse the json format metric to prometheus message type and export to prometheus monitor port, so those metrics can be displayed in grafana. Please help check those changes, if it's ok, i will update the metric document.
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
…etheus (apache#6705) ## Motivation The managed ledger read cache monitor metric is export via /admin/broker-stats/metrics with json format, it is hard to parse, collect and display, what's more the read cache is a very import module for message consuming throughput and latency. So collect and display the read cache metrics is extremely urgent for pulsar in production. ## Changes I parse the json format metric to prometheus message type and export to prometheus monitor port, so those metrics can be displayed in grafana. Please help check those changes, if it's ok, i will update the metric document.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…etheus (apache#6705) ## Motivation The managed ledger read cache monitor metric is export via /admin/broker-stats/metrics with json format, it is hard to parse, collect and display, what's more the read cache is a very import module for message consuming throughput and latency. So collect and display the read cache metrics is extremely urgent for pulsar in production. ## Changes I parse the json format metric to prometheus message type and export to prometheus monitor port, so those metrics can be displayed in grafana. Please help check those changes, if it's ok, i will update the metric document.
cdbartholomew
added a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Sep 11, 2020
… to prometheus (apache#6705)" This reverts commit a9ed984.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The managed ledger read cache monitor metric is export via /admin/broker-stats/metrics with json format, it is hard to parse, collect and display, what's more the read cache is a very import module for message consuming throughput and latency. So collect and display the read cache metrics is extremely urgent for pulsar in production.
Changes
I parse the json format metric to prometheus message type and export to prometheus monitor port, so those metrics can be displayed in grafana.
Please help check those changes, if it's ok, i will update the metric document.