[pulsar-client] Add deliver_at and deliver_after to python client #6737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new function deliverAfter that takes the MessageBuilder and a py::object. Python object is reinterpreted as PyDateTime_Delta then convert to a std::chrono::duration and then the builder property is setted. After that we return the builder. Signed-off-by: Guillaume Perrin <guillaume28.perrin@gmail.com>
Use PyObject* instead of boost::python::api::object since we want to cast to another python object, PyDateTime_Delta. Signed-off-by: Guillaume Perrin <guillaume28.perrin@gmail.com>
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
sijie
added
the
type/feature
merlimat
approved these changes
Apr 15, 2020
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
May 15, 2020
…ache#6737) * Add deliver_at and deliver_after to python client * Fix deliver_at test * Fix deliver_after function binding for Python Create a new function deliverAfter that takes the MessageBuilder and a py::object. Python object is reinterpreted as PyDateTime_Delta then convert to a std::chrono::duration and then the builder property is setted. After that we return the builder. Signed-off-by: Guillaume Perrin <guillaume28.perrin@gmail.com> * Fix cast of datetime in setDeliverAfter in python library Use PyObject* instead of boost::python::api::object since we want to cast to another python object, PyDateTime_Delta. Signed-off-by: Guillaume Perrin <guillaume28.perrin@gmail.com> * Fix test comment * Remove unused import Co-authored-by: Yoann Ciabaud <yoann@linxo.com> Co-authored-by: Guillaume Perrin <guillaume28.perrin@gmail.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…ache#6737) * Add deliver_at and deliver_after to python client * Fix deliver_at test * Fix deliver_after function binding for Python Create a new function deliverAfter that takes the MessageBuilder and a py::object. Python object is reinterpreted as PyDateTime_Delta then convert to a std::chrono::duration and then the builder property is setted. After that we return the builder. Signed-off-by: Guillaume Perrin <guillaume28.perrin@gmail.com> * Fix cast of datetime in setDeliverAfter in python library Use PyObject* instead of boost::python::api::object since we want to cast to another python object, PyDateTime_Delta. Signed-off-by: Guillaume Perrin <guillaume28.perrin@gmail.com> * Fix test comment * Remove unused import Co-authored-by: Yoann Ciabaud <yoann@linxo.com> Co-authored-by: Guillaume Perrin <guillaume28.perrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Delayed message delivery is available in C++ client but not in Python client, as a Python client user, I would like to benefit from this feature as well.
Modifications
Update of the C++ messagebuilder Python binding to expose
deliver_atanddeliver_afterto the Python API.Update of the Python client to add these features to the producer sending method.
Verifying this change
This change added tests and can be verified as follows:
deliver_atanddeliver_afterDoes this pull request potentially affect one of the following parts:
This PR affects the python public API with new parameters for python producer
sendandsendAsyncmethodsdeliver_atanddeliver_after.Documentation
This feature is documented in the python source code.