Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python client]Support generate pulsar-client for python3.8 #6741

Merged
merged 2 commits into from
Apr 15, 2020
Merged

[python client]Support generate pulsar-client for python3.8 #6741

merged 2 commits into from
Apr 15, 2020

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Apr 15, 2020

Fixes #5846

Motivation

  • Support python3.8 for pulsar client

Modifications

  • Add 3.8 cp38-cp38 for support generate pulsar client package

Verifying this change

Local test pass use docker image pulsar-build:manylinux-cp38-cp38

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@tuteng tuteng self-assigned this Apr 15, 2020
@sijie sijie merged commit ab1f40d into apache:master Apr 15, 2020
@sijie sijie deleted the fix/support-generate-package-for-python3.8 branch April 15, 2020 08:27
tuteng added a commit that referenced this pull request Apr 15, 2020
@tuteng
[python client]Support generate pulsar-client for python3.8 (#6741)
c36170c 
* Support pulsar-client for python3.8

* Fixed python38

(cherry picked from commit ab1f40d)
This was referenced Apr 16, 2020
Closed
Closed
jiazhai pushed a commit to jiazhai/pulsar that referenced this pull request May 18, 2020
@tuteng @jiazhai
[python client]Support generate pulsar-client for python3.8 (apache#6741
d1e894c 
)

* Support pulsar-client for python3.8

* Fixed python38
(cherry picked from commit ab1f40d)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@tuteng @huangdx0726
[python client]Support generate pulsar-client for python3.8 (apache#6741
56cf7aa 
)

* Support pulsar-client for python3.8

* Fixed python38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@aahmed-se aahmed-se aahmed-se approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@jiazhai jiazhai Awaiting requested review from jiazhai

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@tuteng tuteng

Labels
area/client release/2.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pulsar-client-cpp/python] pypi has no tracked versions of the client for python 3.8
3 participants
@tuteng @sijie @aahmed-se