Fix check backlogged cursors without consumer #6766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sijie
approved these changes
Apr 21, 2020
|
/pulsarbot run-failure-checks |
sijie
added
area/broker
release/2.5.2
type/enhancement
codelipenghui
approved these changes
Apr 22, 2020
merlimat
approved these changes
Apr 22, 2020
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
May 7, 2020
* fix the backlogged cursors bug * add some test * change test case * change test case * change test case * change check logical * move backlogged cursor check after consumer add Co-authored-by: zhaorongsheng <zhaorongsheng@bigo.sg>
jiazhai
pushed a commit
that referenced
this pull request
May 8, 2020
* fix the backlogged cursors bug * add some test * change test case * change test case * change test case * change check logical * move backlogged cursor check after consumer add Co-authored-by: zhaorongsheng <zhaorongsheng@bigo.sg>(cherry picked from commit 4d59f2b)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* fix the backlogged cursors bug * add some test * change test case * change test case * change test case * change check logical * move backlogged cursor check after consumer add Co-authored-by: zhaorongsheng <zhaorongsheng@bigo.sg>
15 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the subscription's all consumer has been closed, the cursor will be set to inactive. But the cursor will be set to active during
PulsarStats.updateStats()when the backlog size is less thanbackloggedCursorThresholdEntries. Obviously it's not the right thing.Modifications
Move the
checkBackloggedCursors()fromManagedLedgertoTopicand check the consumer list as well.