support async send msg return sequenceId when throw Exception #6825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
added
area/client
type/enhancement
sijie
approved these changes
Apr 29, 2020
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Apr 30, 2020
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
…#6825) Master Issue: apache#6824 ## Motivation When sending messages asynchronously fails, an exception will be thrown, but it is not known which message is abnormal, and the user does not know which messages need to be retried。 ## Modifications This change can be supported on the client side, when throwing an exception need to set sequenceId org.apache.pulsar.client.api.PulsarClientException ```java public class PulsarClientException extends IOException { private long sequenceId = -1; public PulsarClientException(String msg, long sequenceId) { super(msg); this.sequenceId = sequenceId; } ``` Client examples ```java producer.newMessage().sequenceId(1).value(value.getBytes()) .sendAsync().thenAccept(msgId -> { System.out.println(msgId); }).exceptionally(ex -> { System.out.println( ((PulsarClientException)ex.getCause()).getSequenceId()); return null; }); ```
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…#6825) Master Issue: apache#6824 ## Motivation When sending messages asynchronously fails, an exception will be thrown, but it is not known which message is abnormal, and the user does not know which messages need to be retried。 ## Modifications This change can be supported on the client side, when throwing an exception need to set sequenceId org.apache.pulsar.client.api.PulsarClientException ```java public class PulsarClientException extends IOException { private long sequenceId = -1; public PulsarClientException(String msg, long sequenceId) { super(msg); this.sequenceId = sequenceId; } ``` Client examples ```java producer.newMessage().sequenceId(1).value(value.getBytes()) .sendAsync().thenAccept(msgId -> { System.out.println(msgId); }).exceptionally(ex -> { System.out.println( ((PulsarClientException)ex.getCause()).getSequenceId()); return null; }); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #6824
Motivation
When sending messages asynchronously fails, an exception will be thrown, but it is not known which message is abnormal, and the user does not know which messages need to be retried。
Modifications
This change can be supported on the client side, when throwing an exception need to set sequenceId
org.apache.pulsar.client.api.PulsarClientException
Client examples