[Broker] Handle all exceptions from topic.addProducer
#6881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#6872 Fixes apache#6416 If a producer tries to create a producer to a topic that is currently unloading, we can get a `RuntimeException` from `BrokerService.checkTopicNsOwnership` which is bubbled up through `topic.addProducer`. By only handling a `BrokerServiceException` this results in a future that never completes and results in producers not being able to be created if this topic is scheduled back to this broker.
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
May 6, 2020
codelipenghui
approved these changes
May 6, 2020
jiazhai
pushed a commit
that referenced
this pull request
May 8, 2020
Fixes #6872 Fixes #6416 If a producer tries to create a producer to a topic that is currently unloading, we can get a `RuntimeException` from `BrokerService.checkTopicNsOwnership` which is bubbled up through `topic.addProducer`. By only handling a `BrokerServiceException` this results in a future that never completes and results in producers not being able to be created if this topic is scheduled back to this broker. (cherry picked from commit 30e26f8)
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
May 12, 2020
Fixes apache#6872 Fixes apache#6416 If a producer tries to create a producer to a topic that is currently unloading, we can get a `RuntimeException` from `BrokerService.checkTopicNsOwnership` which is bubbled up through `topic.addProducer`. By only handling a `BrokerServiceException` this results in a future that never completes and results in producers not being able to be created if this topic is scheduled back to this broker.
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
Fixes apache#6872 Fixes apache#6416 If a producer tries to create a producer to a topic that is currently unloading, we can get a `RuntimeException` from `BrokerService.checkTopicNsOwnership` which is bubbled up through `topic.addProducer`. By only handling a `BrokerServiceException` this results in a future that never completes and results in producers not being able to be created if this topic is scheduled back to this broker.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#6872 Fixes apache#6416 If a producer tries to create a producer to a topic that is currently unloading, we can get a `RuntimeException` from `BrokerService.checkTopicNsOwnership` which is bubbled up through `topic.addProducer`. By only handling a `BrokerServiceException` this results in a future that never completes and results in producers not being able to be created if this topic is scheduled back to this broker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6872
Fixes #6416
Motivation
If a producer tries to create a producer to a topic that is currently
unloading, we can get a
RuntimeExceptionfromBrokerService.checkTopicNsOwnershipwhich is bubbled up throughtopic.addProducer. By only handling aBrokerServiceExceptionthisresults in a future that never completes and results in producers not
being able to be created if this topic is scheduled back to this broker.
Modifications
Change to handling all exceptions
Verifying this change
This could use a test, but I am currently not sure where would be the best place to test it. Existing tests should pass.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation