Secrets provider should be initialized for each new function #6993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahmed-se
approved these changes
May 19, 2020
srkukarni
approved these changes
May 19, 2020
|
/pulsarbot run-failure-checks |
8 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
jerrypeng
force-pushed
the
fix_thread_runtime_secrets_provider_init
branch
from
fe397e7
to
9e7054d
Compare
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
…6993) * Secrets provider should be initialized for each new function * add comment Co-authored-by: Jerry Peng <jerryp@splunk.com>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
…6993) * Secrets provider should be initialized for each new function * add comment Co-authored-by: Jerry Peng <jerryp@splunk.com>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 12, 2020
…6993) * Secrets provider should be initialized for each new function * add comment Co-authored-by: Jerry Peng <jerryp@splunk.com>
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Jun 30, 2020
…6993) * Secrets provider should be initialized for each new function * add comment Co-authored-by: Jerry Peng <jerryp@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…6993) * Secrets provider should be initialized for each new function * add comment Co-authored-by: Jerry Peng <jerryp@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A new instance of the secrets provider should be constructed for each function. This is the behavior for other runtimes and prevents different functions accessing the state of the same secrets provider which can be dangerous