Fixed increasing number of partitions with attached readers #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
requested review from
ivankelly,
srkukarni,
rdhabalia,
jerrypeng,
aahmed-se and
codelipenghui
aahmed-se
approved these changes
May 28, 2020
codelipenghui
approved these changes
May 29, 2020
jiazhai
approved these changes
May 30, 2020
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
) When we're increasing the number of partitions in a topic, we typically also pre-create the subscriptions on those topics. In this case, we're also pre-creating the non-durable subscriptions of the readers. These are getting created as durable subscriptions on the new partitions and will be leaked and causing backlogs. Instead, we don't need to pre-create anything for readers (non-durable subscriptions). * Fixed increasing number of partitions with attached readers * Fixed test expectation after merge
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
) When we're increasing the number of partitions in a topic, we typically also pre-create the subscriptions on those topics. In this case, we're also pre-creating the non-durable subscriptions of the readers. These are getting created as durable subscriptions on the new partitions and will be leaked and causing backlogs. Instead, we don't need to pre-create anything for readers (non-durable subscriptions). * Fixed increasing number of partitions with attached readers * Fixed test expectation after merge
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 12, 2020
) When we're increasing the number of partitions in a topic, we typically also pre-create the subscriptions on those topics. In this case, we're also pre-creating the non-durable subscriptions of the readers. These are getting created as durable subscriptions on the new partitions and will be leaked and causing backlogs. Instead, we don't need to pre-create anything for readers (non-durable subscriptions). * Fixed increasing number of partitions with attached readers * Fixed test expectation after merge
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
) When we're increasing the number of partitions in a topic, we typically also pre-create the subscriptions on those topics. In this case, we're also pre-creating the non-durable subscriptions of the readers. These are getting created as durable subscriptions on the new partitions and will be leaked and causing backlogs. Instead, we don't need to pre-create anything for readers (non-durable subscriptions). * Fixed increasing number of partitions with attached readers * Fixed test expectation after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we're increasing the number of partitions in a topic, we typically also pre-create the subscriptions on those topics. In this case, we're also pre-creating the non-durable subscriptions of the readers.
These are getting created as durable subscriptions on the new partitions and will be leaked and causing backlogs.
Instead, we don't need to pre-create anything for readers (non-durable subscriptions).