Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset msg backlog and backlog size #7082

Merged
merged 1 commit into from
May 28, 2020
Merged

Reset msg backlog and backlog size #7082

merged 1 commit into from
May 28, 2020

Conversation

sijie
Copy link
Member

@sijie sijie commented May 28, 2020 •
edited
Loading

Motivation

There are a couple of prometheus stats issues.

  • The backlogSize isn't reset after being collected by Prometheus. This result in backlogSize keeps growing.
  • Pulsar out rate is 0

Modifications

  • reset a few counters in AggregatedNamespaceStats
  • Fix the out rate being 0 isse

@sijie sijie added this to the 2.6.0 milestone May 28, 2020
@sijie sijie self-assigned this May 28, 2020
@codelipenghui codelipenghui merged commit e86c4c8 into apache:master May 28, 2020
@sijie sijie deleted the fix_msgbacklog_size branch May 28, 2020 17:33
This was referenced May 28, 2020
Closed
Closed
315157973 pushed a commit to 315157973/pulsar that referenced this pull request May 29, 2020
@sijie @315157973
Reset msg backlog and backlog size (apache#7082)
e306ec9
@sijie sijie mentioned this pull request May 30, 2020
Closed
1 task
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
@sijie @Huanli-Meng
Reset msg backlog and backlog size (apache#7082)
aeec325
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
@sijie @Huanli-Meng
Reset msg backlog and backlog size (apache#7082)
a1860fc
@sijie sijie mentioned this pull request Jun 10, 2020
Closed
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 12, 2020
@sijie @Huanli-Meng
Reset msg backlog and backlog size (apache#7082)
1565b30
@codelipenghui codelipenghui mentioned this pull request Jul 9, 2020
Closed
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@sijie @huangdx0726
Reset msg backlog and backlog size (apache#7082)
565374d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazhai jiazhai jiazhai approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@tuteng tuteng Awaiting requested review from tuteng

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

Assignees

@sijie sijie

Labels
area/broker release/2.5.3
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sijie @jiazhai @codelipenghui