add feature: enable maxSizePerLedger settings in configuration #7085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
May 28, 2020
| @@ -704,6 +704,9 @@ managedLedgerMinLedgerRolloverTimeMinutes=10 | |||
| # Maximum time before forcing a ledger rollover for a topic | |||
| managedLedgerMaxLedgerRolloverTimeMinutes=240 | |||
|
|
|||
| # Maximum ledger size before triggering a rollover for a topic (MB) | |||
| managedLedgerMaxSizePerLedgerMbytes=2048 | |||
There was a problem hiding this comment.
Can you also add this config into conf/standalone.conf?
There was a problem hiding this comment.
Thank you for your timely feedback. I have added the configuration in conf/standalone.conf.
merlimat
approved these changes
May 29, 2020
merlimat
added
the
type/enhancement
codelipenghui
approved these changes
May 31, 2020
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
…e#7085) * add feature: enable maxSizePerLedger settings in configuration * add feature: enable maxSizePerLedger settings in configuration Co-authored-by: wuzhanpeng <wuzhanpeng@bigo.sg>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
…e#7085) * add feature: enable maxSizePerLedger settings in configuration * add feature: enable maxSizePerLedger settings in configuration Co-authored-by: wuzhanpeng <wuzhanpeng@bigo.sg>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 12, 2020
…e#7085) * add feature: enable maxSizePerLedger settings in configuration * add feature: enable maxSizePerLedger settings in configuration Co-authored-by: wuzhanpeng <wuzhanpeng@bigo.sg>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…e#7085) * add feature: enable maxSizePerLedger settings in configuration * add feature: enable maxSizePerLedger settings in configuration Co-authored-by: wuzhanpeng <wuzhanpeng@bigo.sg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request implements an entrance to set max size per ledger in configuration file (
conf/broker.conf). Currently the default ledger rollover size is hardcode to2048MBwhen initializing broker inBrokerService.Expected behaviors
If the user does not use the setting, the behaviors are the same as before. If the user sets
managedLedgerMaxSizePerLedgerMbytesinconf/broker.conf, then the setting value will be used.Modifications
conf/broker.confandServiceConfiguration)BrokerService)