Message replays on Key shared subscription are breaking ordering #7108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
rdhabalia,
jerrypeng,
aahmed-se and
codelipenghui
codelipenghui
approved these changes
Jun 6, 2020
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 24, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is based on top of #6791, #7104, #7105, #7106 and #7107. Once these are merged, I'll rebase here. For the sake of this review, check commit 3afe89bMotivation
When doing replays, the key shared dispatcher is relying on the
ConcurrentSortedLongPairSetfor getting message ids in order. That set though is only doing a best-effort sorting, resulting in out of order errors. We need to ensure the ordering.