fix support set nettyMaxFrameSizeBytes on bookeeper config #7116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
May 31, 2020
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jun 1, 2020
conf/bookkeeper.conf
Outdated
| @@ -268,6 +268,9 @@ serverTcpNoDelay=true | |||
| # The Recv ByteBuf allocator max buf size. | |||
| # byteBufAllocatorSizeMax=1048576 | |||
|
|
|||
| # The maximum netty frame size in bytes. Any message received larger than this will be rejeted. Default value is 1G. | |||
There was a problem hiding this comment.
Suggested change
| # The maximum netty frame size in bytes. Any message received larger than this will be rejeted. Default value is 1G. | |
| # The maximum netty frame size in bytes. Any message received larger than this will be rejected. The default value is 1G. |
There was a problem hiding this comment.
@liudezhi2098 It's better to use 5MB as the default value, in order to avoid the change of the default value to break the use of some scenes.
There was a problem hiding this comment.
use 5MB as the default value , will cause problems，can be changed to 5253120（
5242880 + Commands.MESSAGE_SIZE_FRAME_PADDING）
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Jun 1, 2020
…meSizeBytes_config
|
/pulsarbot run-failure-checks |
…meSizeBytes_config
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Master Issue: apache#7115 ## Motivation fix by default config , when the content of the sent message is 5M, it will appear that the current topic can no longer send the message. ## Modifications bookkeeper.con f ```java # The maximum netty frame size in bytes. Any message received larger than this will be rejeted. Default value is 1G. nettyMaxFrameSizeBytes=1073741824 ``` The default setting is 1G size, I think it should be larger than the broker's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #7115
Motivation
fix by default config , when the content of the sent message is 5M, it will appear that the current topic can no longer send the message.
Modifications
bookkeeper.con f
The default setting is 1G size, I think it should be larger than the broker's