Allow to delete topics that are failing to recover #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
rdhabalia,
jerrypeng and
codelipenghui
codelipenghui
approved these changes
Jun 2, 2020
sijie
approved these changes
Jun 2, 2020
|
Will the topic deletion work on geo-replicated topics too? Because at this moment, for the namespaces that are geo-replicated, the topics doesn't get deleted even if we try disabling the replication by set-clusters. |
|
@Saswatibhoi that is a different issue. For geo-replicated topics, typically the suggestion is to stop using them and unsubscribe, leaving the topic to get auto-deleted. Surely, there could be an improvement to perform deletion on geo-replicated topics. |
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 12, 2020
### Motivation If a topic is failing to recover, it's currently practically impossible to force the deletion, other than going to delete the metadata from ZK directly. The failure to recover can happen when data for the last ledger is missing and the ledger fails causing the topic to be offline. This could be due to manual error (eg: increasing and decreasing the bookie replicas without waiting to auto-recovery). If we want to delete a topic and move on, we shouldn't fail if the data itself is corrupted/missing.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation If a topic is failing to recover, it's currently practically impossible to force the deletion, other than going to delete the metadata from ZK directly. The failure to recover can happen when data for the last ledger is missing and the ledger fails causing the topic to be offline. This could be due to manual error (eg: increasing and decreasing the bookie replicas without waiting to auto-recovery). If we want to delete a topic and move on, we shouldn't fail if the data itself is corrupted/missing.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If a topic is failing to recover, it's currently practically impossible to force the deletion, other than going to delete the metadata from ZK directly.
The failure to recover can happen when data for the last ledger is missing and the ledger fails causing the topic to be offline. This could be due to manual error (eg: increasing and decreasing the bookie replicas without waiting to auto-recovery).
If we want to delete a topic and move on, we shouldn't fail if the data itself is corrupted/missing.