Attach names for all producers/readers in worker service #7165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srkukarni can you also add for the producer in the FunctionMetadataManager |
|
@jerrypeng Its already added. |
jerrypeng
reviewed
Jun 4, 2020
...nctions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
Show resolved
Hide resolved
jerrypeng
approved these changes
Jun 4, 2020
|
@srkukarni that is the place. I must have missed it |
jerrypeng
reviewed
Jun 4, 2020
| @@ -106,6 +106,7 @@ public SchedulerManager(WorkerConfig workerConfig, PulsarClient pulsarClient, Pu | |||
| .blockIfQueueFull(true) | |||
| .compressionType(CompressionType.LZ4) | |||
| .sendTimeout(0, TimeUnit.MILLISECONDS) | |||
| .producerName(config.getWorkerId() + "-scheduler-manager") | |||
There was a problem hiding this comment.
can you also add
.subscriptionRolePrefix(workerConfig.getWorkerId())
There was a problem hiding this comment.
Producer name needs to be unique, so we better put this in the producer properties instead.
There was a problem hiding this comment.
Actually, in this case it should be good since there's only 1 writer.
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Jun 30, 2020
* Attach names for all producers/readers in worker service * Fix tests Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 24, 2020
* Attach names for all producers/readers in worker service * Fix tests Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Attach names for all producers/readers in worker service * Fix tests Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
This pr attaches names for all the producers/readers that worker service utilizes. This is very useful for debugging.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation