-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
function to read compacted topics #7193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
Show resolved
Hide resolved
sijie
requested changes
Jun 8, 2020
@jerrypeng @sijie Would you please help review this PR again? |
/pulsarbot run-failure-checks |
sijie
approved these changes
Jul 2, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#5538 ### Motivation ### Modifications In function mode and sink mode, PulsarSource can read compacted topic。 By `inputSpecs` parameter, each topic can independently decide whether to read compacted ### Verifying this change unit test: org.apache.pulsar.io.PulsarFunctionE2ETest#testReadCompactedFunction org.apache.pulsar.io.PulsarFunctionE2ETest#testReadCompactedSink
How does one configure their function to read from a compacted topic? the current documentation doesn't seem to mention it and it's not obvious looking at the code of this PR. Does it happen automatically? does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5538
Motivation
Modifications
In function mode and sink mode, PulsarSource can read compacted topic。
By
inputSpecs
parameter, each topic can independently decide whether to read compactedVerifying this change
unit test:
org.apache.pulsar.io.PulsarFunctionE2ETest#testReadCompactedFunction
org.apache.pulsar.io.PulsarFunctionE2ETest#testReadCompactedSink
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation