Have metadata tailer use its own thread for processing #7211
Conversation
| @@ -69,28 +106,13 @@ public void processRequest(Message<byte[]> msg) { | |||
| serviceRequest = ServiceRequest.parseFrom(msg.getData()); | |||
| } catch (IOException e) { | |||
| log.error("Received bad service request at message {}", msg.getMessageId(), e); | |||
| // TODO: find a better way to handle bad request | |||
| throw new RuntimeException(e); | |||
| errorNotifier.triggerError(e); | |||
There was a problem hiding this comment.
Should we just remove the try-catch and let the method throw an exception? Everything is caught in the thread anyways.
There was a problem hiding this comment.
We would still need to differentiate Interrupted vs others. And if we do encounter some exception isn;'t it better to trigger the errorNotifier and exit perhaps?
There was a problem hiding this comment.
We would still need to differentiate Interrupted vs others.
I don't quite follow, the code already differentiates interrupted exceptions vs other exceptions.
Triggering the error in the catch all block in the thread allows us to exit the thread as well and stop further processing of requests. While this doesn't hurt but is cleaner in a sense.
There was a problem hiding this comment.
I misunderstood your comments. Yes, that makes sense. Fixed
| throws PulsarClientException { | ||
| this.functionMetaDataManager = functionMetaDataManager; | ||
| this.reader = reader; | ||
| this.reader = readerBuilder | ||
| .topic(workerConfig.getFunctionMetadataTopic()) |
There was a problem hiding this comment.
Can you also set the subscription prefix:
subscriptionRolePrefix(workerConfig.getWorkerId() + "-function-metadata-manager")
* Have metadata tailer use its own thread for processing * Merged with master * Address comments * Address comments Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
* Have metadata tailer use its own thread for processing * Merged with master * Address comments * Address comments Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
* Have metadata tailer use its own thread for processing * Merged with master * Address comments * Address comments Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
|
needs to cherry-pick to 2.6.2. |
* Have metadata tailer use its own thread for processing * Merged with master * Address comments * Address comments Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com> (cherry picked from commit e64d951)
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Following up on #7180, this pr does the same thing for function metadata tailer.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation