Add an endpoint to check whether function worker service is initialized #7350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cckellogg please also review |
srkukarni
approved these changes
Jun 24, 2020
|
/pulsarbot run-failure-checks |
cckellogg
reviewed
Jun 24, 2020
| @ApiResponse(code = 400, message = "Invalid request"), | ||
| @ApiResponse(code = 408, message = "Request timeout") | ||
| }) | ||
| @Path("/initialized") |
There was a problem hiding this comment.
What is the full path for this? Will callers need to be authenticated? If so we might want to make that optional (like the metrics endpoint). Otherwise, using this as a readiness/liveness probe in kubernetes will be difficult.
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
jerrypeng
force-pushed
the
initialized_endpoint
branch
from
630295b
to
18dbec4
Compare
|
/pulsarbot run-failure-checks |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…ed (apache#7350) * Add an endpoint to check whether function worker service is initialized Co-authored-by: Jerry Peng <jerryp@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add an endpoint to check whether function worker service is initialized. This endpoint can be used as a readiness check