Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Reduce log level for ack-grouping tracker #7373

Merged
merged 1 commit into from
Jun 27, 2020
Merged

[C++] Reduce log level for ack-grouping tracker #7373

merged 1 commit into from
Jun 27, 2020

Conversation

merlimat
Copy link
Contributor

Motivation

The C++ ack tracker is printing a lot of warning (every 100ms) for something which is perfectly normal (eg: not able to talk with broker at the moment).

2020-06-26 13:58:55.935 WARN  [0x7000032a0000] AckGroupingTrackerEnabled:99 | Connection is not ready, grouping ACK failed.
2020-06-26 13:58:56.038 WARN  [0x7000032a0000] AckGroupingTrackerEnabled:99 | Connection is not ready, grouping ACK failed.
2020-06-26 13:58:56.141 WARN  [0x7000032a0000] AckGroupingTrackerEnabled:99 | Connection is not ready, grouping ACK failed.
2020-06-26 13:58:56.244 WARN  [0x7000032a0000] AckGroupingTrackerEnabled:99 | Connection is not ready, grouping ACK failed.
2020-06-26 13:58:56.344 WARN  [0x7000032a0000] AckGroupingTrackerEnabled:99 | Connection is not ready, grouping ACK failed.
.....

@merlimat merlimat added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages component/c++ release/2.6.1 labels Jun 26, 2020
@merlimat merlimat added this to the 2.7.0 milestone Jun 26, 2020
@merlimat merlimat self-assigned this Jun 26, 2020
@merlimat merlimat merged commit 4138e71 into apache:master Jun 27, 2020
codelipenghui pushed a commit to streamnative/pulsar-archived that referenced this pull request Jul 14, 2020
@merlimat @codelipenghui
[C++] Reduce log level for ack-grouping tracker (apache#7373)
7ce7041 
(cherry picked from commit 4138e71)
wolfstudy pushed a commit that referenced this pull request Jul 29, 2020
@merlimat @wolfstudy
[C++] Reduce log level for ack-grouping tracker (#7373)
828eb43 
(cherry picked from commit 4138e71)
@BewareMyPower BewareMyPower mentioned this pull request Aug 5, 2020
Closed
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@merlimat @huangdx0726
[C++] Reduce log level for ack-grouping tracker (apache#7373)
e6ee224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@sijie sijie Awaiting requested review from sijie

@srkukarni srkukarni Awaiting requested review from srkukarni

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@aahmed-se aahmed-se Awaiting requested review from aahmed-se

@massakam massakam Awaiting requested review from massakam

Assignees

@merlimat merlimat

Labels
release/2.6.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@merlimat @codelipenghui