[Issue 7347] Avoid the NPE occurs in method ManagedLedgerImpl.isOffloadedNeedsDelete
#7389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
changed the title
merlimat
reviewed
Jun 30, 2020
| @@ -41,7 +41,7 @@ | |||
| public final static String[] DRIVER_NAMES = {"S3", "aws-s3", "google-cloud-storage", "filesystem"}; | |||
| public final static String DEFAULT_OFFLOADER_DIRECTORY = "./offloaders"; | |||
| public final static long DEFAULT_OFFLOAD_THRESHOLD_IN_BYTES = -1; | |||
| public final static Long DEFAULT_OFFLOAD_DELETION_LAG_IN_MILLIS = null; | |||
| public final static long DEFAULT_OFFLOAD_DELETION_LAG_IN_MILLIS = -1; | |||
There was a problem hiding this comment.
Should we also change managedLedgerOffloadDeletionLagInMillis to long?
There was a problem hiding this comment.
This default is couldn't be Null, so I changed this field type to long.
There was a problem hiding this comment.
Yes, it's fine. I was just saying to also change the type for the managedLedgerOffloadDeletionLagInMillis field which is currently Long. If null is not a valid value, we should use long type instead.
There was a problem hiding this comment.
Yes, I changed it. Thanks.
merlimat
approved these changes
Jul 1, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jul 1, 2020
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Jul 2, 2020
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
gaoran10
changed the title
ManagedLedgerImpl.isOffloadedNeedsDelete
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jul 14, 2020
…oadedNeedsDelete` (apache#7389) Fixes apache#7347 ### Motivation The default value of the offload-deletion-lag is `null`, this will cause an NPE problem. ### Modifications Add null check in the method `ManagedLedgerImpl.isOffloadedNeedsDelete`. ### Verifying this change Add unit test for method `ManagedLedgerImpl.isOffloadedNeedsDelete`. (cherry picked from commit eaf268c)
|
I'm trying to work around this until 2.6.1 is released. Not sure what to do.
From the docs I thought the default value would be 14400000 Will explicitly setting a value for this setting help? |
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 21, 2020
…oadedNeedsDelete` (apache#7389) Fixes apache#7347 ### Motivation The default value of the offload-deletion-lag is `null`, this will cause an NPE problem. ### Modifications Add null check in the method `ManagedLedgerImpl.isOffloadedNeedsDelete`. ### Verifying this change Add unit test for method `ManagedLedgerImpl.isOffloadedNeedsDelete`.
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 24, 2020
…oadedNeedsDelete` (apache#7389) Fixes apache#7347 ### Motivation The default value of the offload-deletion-lag is `null`, this will cause an NPE problem. ### Modifications Add null check in the method `ManagedLedgerImpl.isOffloadedNeedsDelete`. ### Verifying this change Add unit test for method `ManagedLedgerImpl.isOffloadedNeedsDelete`.
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
…oadedNeedsDelete` (#7389) Fixes #7347 ### Motivation The default value of the offload-deletion-lag is `null`, this will cause an NPE problem. ### Modifications Add null check in the method `ManagedLedgerImpl.isOffloadedNeedsDelete`. ### Verifying this change Add unit test for method `ManagedLedgerImpl.isOffloadedNeedsDelete`. (cherry picked from commit eaf268c)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…oadedNeedsDelete` (apache#7389) Fixes apache#7347 ### Motivation The default value of the offload-deletion-lag is `null`, this will cause an NPE problem. ### Modifications Add null check in the method `ManagedLedgerImpl.isOffloadedNeedsDelete`. ### Verifying this change Add unit test for method `ManagedLedgerImpl.isOffloadedNeedsDelete`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7347
Motivation
The default value of the offload-deletion-lag is
null, this will cause an NPE problem.Modifications
Add null check in the method
ManagedLedgerImpl.isOffloadedNeedsDelete.Verifying this change
Add unit test for method
ManagedLedgerImpl.isOffloadedNeedsDelete.Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation