Avoid NPEs at ledger creation when DNS failures happen #7403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
requested review from
ivankelly,
sijie,
srkukarni,
rdhabalia,
jerrypeng and
codelipenghui
sijie
approved these changes
Jun 30, 2020
|
@merlimat thank you for taking care of these places! |
sijie
reviewed
Jun 30, 2020
| }, LedgerMetadataUtils.buildAdditionalMetadataForCursor(name)); | ||
| } catch (Throwable t) { | ||
| log.error("[{}] Encountered unexpected error when creating cursor ledger", name, t); | ||
| callback.operationFailed(new ManagedLedgerException(t)); |
There was a problem hiding this comment.
actually I don't think we need this change here. The exception is already handled in ledger.asyncCreateLedger
There was a problem hiding this comment.
Correct. let me pull that back
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jul 14, 2020
* Avoid NPEs at ledger creation when DNS failures happen * Removed unnecessary try/catch (cherry picked from commit a230427)
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 21, 2020
* Avoid NPEs at ledger creation when DNS failures happen * Removed unnecessary try/catch
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 24, 2020
* Avoid NPEs at ledger creation when DNS failures happen * Removed unnecessary try/catch
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
* Avoid NPEs at ledger creation when DNS failures happen * Removed unnecessary try/catch (cherry picked from commit a230427)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Avoid NPEs at ledger creation when DNS failures happen * Removed unnecessary try/catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a followup to the fix in #7401, also use try/catch in all places where we're creating new ledgers to cover against NPEs triggered by DNS errors.