Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 7407] Support for tombstones (null value in messages) does not work #7408

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

fmiguelez
Copy link
Contributor

@fmiguelez fmiguelez commented Jul 1, 2020

Added check to prevent NPE when a tombstone (null value) is produced.

Fixes #7407

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Null value check

Verifying this change

Tests are provided in #7407. Some similar tests should be integrated into Pulsar code when final solution is presented.

Does this pull request potentially affect one of the following parts:

No

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why? (null check)
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Added check to prevent NPE when a tombstone (null value) is produced.

Documented in apache#7407
@jiazhai
Copy link
Member

jiazhai commented Jul 1, 2020

@gaoran10 @nlu90 Would you please also help review this change?

@sijie
Copy link
Member

sijie commented Jul 2, 2020

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.7.0 milestone Jul 2, 2020
@sijie sijie merged commit 90c2f4a into apache:master Jul 6, 2020
codelipenghui pushed a commit to streamnative/pulsar-archived that referenced this pull request Jul 14, 2020
Added check to prevent NPE when a tombstone (null value) is produced.

Fixes apache#7407

(cherry picked from commit 90c2f4a)
wolfstudy pushed a commit that referenced this pull request Jul 29, 2020
Added check to prevent NPE when a tombstone (null value) is produced.

Fixes #7407

(cherry picked from commit 90c2f4a)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Added check to prevent NPE when a tombstone (null value) is produced.

Fixes apache#7407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for tombstones (null value in messages) does not work
4 participants