Handle NotAllowed Exception at the client side. #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Jul 6, 2020
sijie
approved these changes
Jul 6, 2020
jiazhai
approved these changes
Jul 7, 2020
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
jiazhai
reviewed
Jul 11, 2020
| @@ -196,6 +196,7 @@ enum ServerError { | |||
|
|
|||
| TransactionCoordinatorNotFound = 20; // Transaction coordinator not found error | |||
| InvalidTxnStatus = 21; // Invalid txn status error | |||
| NotAllowedError = 22; // Not allowed error | |||
There was a problem hiding this comment.
From the ci error. we need to handle this new error type in ClientConnection.cc
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jul 17, 2020
* Handle NotAllowed Exception at the client side. (cherry picked from commit f8b2a23)
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
* Handle NotAllowed Exception at the client side. (cherry picked from commit f8b2a23)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Handle NotAllowed Exception at the client side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Handle NotAllowed Exception at the client-side. Currently, if disable the key_shared feature at the broker side, the client will get a UnknownError from the broker and then the client will reconnect again. The reasonable behavior is to return a specific exception to users and let the client stop reconnect.
Modifications
Add NotAllowedError in the ServerError
Verifying this change
testDisableKeySharedSubscriptioncan cover this change.Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation