Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 7450][conf] add gc log print for broker #7498

Merged
merged 1 commit into from
Nov 13, 2020
Merged

[Issue 7450][conf] add gc log print for broker #7498

merged 1 commit into from
Nov 13, 2020

Conversation

shoothzj
Copy link
Member

Fixes #7450

Motivation

Gc log is a useful tool to help our positioning our jvm runing situation. It can use to solve gc param is not reasonable, memory leak. I think if pulsar need this too.

Modifications

I modified start script, add gc log param.

Does this pull request potentially affect one of the following parts:

  • Anything that affects deployment: (yes)

added jvm param.

@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@merlimat
Copy link
Contributor

Wouldn't the GC CLI options be adapted when JVM > 1.8?

@merlimat merlimat added this to the 2.7.0 milestone Jul 11, 2020
@shoothzj
Copy link
Member Author

Wouldn't the GC CLI options be adapted when JVM > 1.8?

What's your meaning ? You want to tune gc options when jvm > 1.8?

If you want to ask if gc log option can work in jvm11 or later ? It can work.

@merlimat
Copy link
Contributor

@shoothzj At least PrintGCDateStamps is not working on Java 11

@codelipenghui codelipenghui modified the milestones: 2.7.0, 2.8.0 Nov 4, 2020
@codelipenghui
Copy link
Contributor

@shoothzj Could you please take a look at the last comment?

@shoothzj
Copy link
Member Author

@shoothzj Could you please take a look at the last comment?

I make it compat on two major java release. java8 and java11.

@codelipenghui
Copy link
Contributor

@shoothzj Seems after apply your last commit, the GC log only can enable in JDK 8 and JDK 11 right?

@shoothzj shoothzj closed this Nov 12, 2020
@shoothzj shoothzj reopened this Nov 12, 2020
@shoothzj
Copy link
Member Author

@shoothzj Seems after apply your last commit, the GC log only can enable in JDK 8 and JDK 11 right?

Yes. It's two mostly use major release version of java. Can we ignore the version less than 8 ? Then I can make it works on jdk 8 and later.

@codelipenghui codelipenghui merged commit 3797f6f into apache:master Nov 13, 2020
@codelipenghui codelipenghui modified the milestones: 2.8.0, 2.7.0 Nov 13, 2020
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
Fixes apache#7450

### Motivation
Gc log is a useful tool to help our positioning our jvm runing situation. It can use to solve gc param is not reasonable, memory leak. I think if pulsar need this too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why start script does not contain gc log
5 participants