Ensure the create subscription can be completed when the operation timeout happens #7522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
added
release/2.6.1
area/client
type/bug
codelipenghui
commented
Jul 13, 2020
| @@ -920,7 +919,6 @@ private void handleSubscribeOneTopicError(String topicName, Throwable error, Com | |||
| log.warn("[{}] Failed to subscribe for topic [{}] in topics consumer, subscribe error: {}", | |||
| topic, topicName, error.getMessage()); | |||
| topics.remove(topicName); | |||
| checkState(allTopicPartitionsNumber.get() == consumers.values().size()); | |||
There was a problem hiding this comment.
This is one topic subscribe error, so we should remove the check with all topic partitions number, Otherwise, the one topic subscribe future can't complete.
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jul 14, 2020
sijie
approved these changes
Jul 14, 2020
codelipenghui
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jul 17, 2020
…meout happens (apache#7522) (cherry picked from commit 6eaf8a6)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Dec 19, 2020
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7521
Motivation
Ensure the create subscription can be completed when the operation timeout happens
Verifying this change
New tests added.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation