[Issue 7489] Remove timestamp from metrics #7539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Jul 15, 2020
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jul 16, 2020
|
@vzhikserg This is great! Thanks for working on this. |
merlimat
added
area/function
component/stats
type/bug
sijie
approved these changes
Jul 17, 2020
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
# Conflicts: # .github/workflows/ci-go-functions-test.yaml
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
* [Issue 7489] Remove timestamp from exception metrics for functions and connectors * [Issue 7489] Remove timestamp from exception metrics for Go functions * [Issue 7489] Remove unused import in go stats * [Issue 7489] Remove timestamp from metrics in python stats * Change to v2 of go github actions * Update go github actions * Remove the version from the go test command * Rename github jobs for go Co-authored-by: Matteo Merli <mmerli@splunk.com> (cherry picked from commit 777ed16)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* [Issue 7489] Remove timestamp from exception metrics for functions and connectors * [Issue 7489] Remove timestamp from exception metrics for Go functions * [Issue 7489] Remove unused import in go stats * [Issue 7489] Remove timestamp from metrics in python stats * Change to v2 of go github actions * Update go github actions * Remove the version from the go test command * Rename github jobs for go Co-authored-by: Matteo Merli <mmerli@splunk.com>
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
* [Issue 7489] Remove timestamp from exception metrics for functions and connectors * [Issue 7489] Remove timestamp from exception metrics for Go functions * [Issue 7489] Remove unused import in go stats * [Issue 7489] Remove timestamp from metrics in python stats * Change to v2 of go github actions * Update go github actions * Remove the version from the go test command * Rename github jobs for go Co-authored-by: Matteo Merli <mmerli@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7489
Motivation
Reduce the number of metrics by removing the label with timestamp (which makes every metric unique and prevents aggregation).
Modifications
The label with timestamp was removed for Java functions and connectors, and Go functions.