[Transaction] Produce transaction messages and commit #7552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
force-pushed
the
tnx-client-server-tandem
branch
from
3c564a0
to
23a279b
Compare
codelipenghui
requested review from
codelipenghui,
sijie,
jiazhai and
merlimat
and removed request for
codelipenghui
|
/pulsarbot run-failure-checks |
4 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
gaoran10
changed the title
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
gaoran10
force-pushed
the
tnx-client-server-tandem
branch
from
656c9af
to
cc99b42
Compare
|
/pulsarbot run-failure-checks |
gaoran10
force-pushed
the
tnx-client-server-tandem
branch
2 times, most recently
from
32081ba
to
8fbcf12
Compare
|
/pulsarbot run-failure-checks |
gaoran10
force-pushed
the
tnx-client-server-tandem
branch
from
8fbcf12
to
ce460c9
Compare
Comment on lines
556
to
557
| transactionBufferProvider = TransactionBufferProvider.newProvider( | ||
| PersistentTransactionBufferProvider.class.getName()); |
There was a problem hiding this comment.
It's better to config in the broker.conf.
| @@ -1212,6 +1221,33 @@ protected void handleSend(CommandSend send, ByteBuf headersAndPayload) { | |||
|
|
|||
| startSendOperation(producer, headersAndPayload.readableBytes(), send.getNumMessages()); | |||
|
|
|||
| final long produceId = producer.getProducerId(); | |||
There was a problem hiding this comment.
It's better to handle the transaction message in the topic, not the server cnx.
There was a problem hiding this comment.
Yes, that's more reasonable.
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
Comment on lines
1712
to
1696
| .thenRun(() -> { | ||
| if (log.isDebugEnabled()) { | ||
| log.debug("Send response success for end txn request {}", command.getRequestId()); | ||
| } | ||
| updateTBStatus(txnID, newStatus).thenRun(() -> { | ||
| service.pulsar().getTransactionMetadataStoreService() | ||
| .updateTxnStatus(txnID, TxnStatus.COMMITTED, TxnStatus.COMMITTING); | ||
| ctx.writeAndFlush(Commands.newEndTxnResponse(requestId, | ||
| txnID.getLeastSigBits(), txnID.getMostSigBits())); | ||
| }).exceptionally(throwable -> { | ||
| log.error("Failed to get txn `" + txnID + "` txnMeta.", throwable); | ||
| ctx.writeAndFlush(Commands.newEndTxnResponse(requestId, txnID.getMostSigBits(), | ||
| BrokerServiceException.getClientErrorCode(throwable), throwable.getMessage())); | ||
| return null; | ||
| }); | ||
| }).exceptionally(throwable -> { | ||
| if (log.isDebugEnabled()) { | ||
| log.debug("Send response error for end txn request {}", command.getRequestId()); | ||
| } | ||
| ctx.writeAndFlush(Commands.newEndTxnResponse(command.getRequestId(), txnID.getMostSigBits(), | ||
| BrokerServiceException.getClientErrorCode(throwable), throwable.getMessage())); | ||
| return null; | ||
| }); |
There was a problem hiding this comment.
We should handle it in the TC and TC should retry to make sure the TB can handle success.
There was a problem hiding this comment.
Yes, I'll fix this.
2. Adjust publish transaction message logic; 2. Integrate with TransactionBufferClientImpl; 3. Update unit test, support multi brokers.
gaoran10
force-pushed
the
tnx-client-server-tandem
branch
from
d8c208e
to
a1f5490
Compare
|
/pulsarbot run-failure-checks |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation Currently, the transaction components are all independent, the relationship between transaction client and transaction server needs to be established. The target of this PR is making the Pulsar client could send transaction messages to the Pulsar broker and execute commit command.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Currently, the transaction components are all independent, the relationship between transaction client and transaction server needs to be established. The target of this PR is making the Pulsar client could send transaction messages to the Pulsar broker and execute commit command.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Currently, the transaction components are all independent, the relationship between transaction client and transaction server needs to be established. The target of this PR is making the Pulsar client could send transaction messages to the Pulsar broker and execute commit command.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Currently, the transaction components are all independent, the relationship between transaction client and transaction server needs to be established. The target of this PR is making the Pulsar client could send transaction messages to the Pulsar broker and execute commit command.
codelipenghui
added
component/transaction
area/transaction
and removed
component/transaction
labels
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #2664
Motivation
Currently, the transaction components are all independent, the relationship between transaction client and transaction server needs to be established.
The target of this PR is making the Pulsar client could send transaction messages to the Pulsar broker and execute commit command.
Modifications
Verifying this change
This change added tests
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation