[C++] Fix multitopic consumer segfault on connect error #7588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
requested review from
sijie,
srkukarni,
aahmed-se,
codelipenghui and
asfsecurity
jiazhai
approved these changes
Jul 18, 2020
|
/pulsarbot run-failure-checks |
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Jul 25, 2020
(cherry picked from commit 09caa92)
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Jul 28, 2020
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
(cherry picked from commit 09caa92)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7577
Motivation
The multi-topic consumer is triggering a segfault when there's an error in creating the consumer. This is due to the calls to close the partial consumers with a null callback.