[Issue 3127][python-client] Replace Exceptions with PulsarExceptions #7600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbenc135
force-pushed
the
feature/pulsar_exception
branch
from
5506d05
to
bc6d73e
Compare
lbenc135
force-pushed
the
feature/pulsar_exception
branch
from
15d9a32
to
3d40f20
Compare
|
Is it possible to re-run all tests? Logs have expired and it's impossible to see what failed:( |
|
@n0nvme rebase and resolve all conflicts first , then push those changes the tests will rerun. |
lbenc135
force-pushed
the
feature/pulsar_exception
branch
3 times, most recently
from
948c06a
to
1566476
Compare
|
@n0nvme @aahmed-se I rebased and improved the PR a bit. Some tests are failing, although they seem flaky to me. Let me know if you have any comments. |
tuteng
approved these changes
Mar 25, 2021
|
@BewareMyPower PTAL |
tuteng
added
component/python
type/enhancement
merlimat
reviewed
Mar 26, 2021
| self.assertTrue(False) # Should not reach this point | ||
| except: | ||
| pass # Exception is expected | ||
| with self.assertRaises(PulsarException): |
There was a problem hiding this comment.
In these tests, could we assert for pulsar.Timeout exception?
merlimat
approved these changes
Mar 26, 2021
lbenc135
force-pushed
the
feature/pulsar_exception
branch
from
1566476
to
f350701
Compare
BewareMyPower
approved these changes
Mar 27, 2021
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7600
Motivation
As the issue says, the Python client throws
Exceptions instead of a subclass of it (PulsarException), so the clients must catch the blanket Exception.Modifications
Every C
PulsarExceptionis now thrown in Python with the same type.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation