fix batchReceiveAsync not completed exceptionally when closing Consumer #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Jul 27, 2020
jiazhai
approved these changes
Jul 28, 2020
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
…er (#7661) ### Motivation CompletableFuture<Messages<T>> from Consumer.batchReceiveAsync() not completed exceptionnally when closing Consumer. ### Modifications pendingBatchReceives was not cleaned up when the connection was closed, so I added pendingBatchReceives cleanup. (cherry picked from commit 48156ad)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…er (apache#7661) ### Motivation CompletableFuture<Messages<T>> from Consumer.batchReceiveAsync() not completed exceptionnally when closing Consumer. ### Modifications pendingBatchReceives was not cleaned up when the connection was closed, so I added pendingBatchReceives cleanup.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…er (apache#7661) ### Motivation CompletableFuture<Messages<T>> from Consumer.batchReceiveAsync() not completed exceptionnally when closing Consumer. ### Modifications pendingBatchReceives was not cleaned up when the connection was closed, so I added pendingBatchReceives cleanup.
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Dec 19, 2020
…er (apache#7661) ### Motivation CompletableFuture<Messages<T>> from Consumer.batchReceiveAsync() not completed exceptionnally when closing Consumer. ### Modifications pendingBatchReceives was not cleaned up when the connection was closed, so I added pendingBatchReceives cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7580
Motivation
CompletableFuture<Messages> from Consumer.batchReceiveAsync() not completed exceptionnally when closing Consumer.
Modifications
pendingBatchReceives was not cleaned up when the connection was closed, so I added pendingBatchReceives cleanup.
Verifying this change
unit test:
org.apache.pulsar.client.api.SimpleProducerConsumerTest#testReceiveAsyncCompletedWhenClosing
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation