Added ability to specify runtime for localrunner #7681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
reviewed
Jul 28, 2020
| @@ -618,6 +618,8 @@ protected void validateFunctionConfigs(FunctionConfig functionConfig) { | |||
| protected Integer DEPRECATED_instanceIdOffset = null; | |||
| @Parameter(names = "--instance-id-offset", description = "Start the instanceIds from this offset") | |||
| protected Integer instanceIdOffset = 0; | |||
| @Parameter(names = "--runtime", description = "either THREAD or PROCESS. Only applies for Java functions") | |||
| protected String runtime = "THREAD"; | |||
There was a problem hiding this comment.
I don't think it makes sense to default to thread runtime especially when users can run functions in python which must be in process runtime. The default should just be null. In LocalRunner, if Java is used the default is thread runtime anyways.
jerrypeng
approved these changes
Jul 28, 2020
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Aug 14, 2020
* Added ability to specify runtime for localrunner * Address feedback Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Added ability to specify runtime for localrunner * Address feedback Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
* Added ability to specify runtime for localrunner * Address feedback Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Currently there is no way to control whether to use Process or Thread runtime for localrun in functions. This pr adds that support
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation