Perform producer compression from IO threads #7733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
merlimat
requested review from
sijie,
srkukarni,
rdhabalia,
jerrypeng and
codelipenghui
srkukarni
approved these changes
Aug 4, 2020
codelipenghui
approved these changes
Aug 4, 2020
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Aug 14, 2020
* Added `zookeeper.snapshot.trust.empty=true` for ZK 3.5 upgrade * Perform producer compression from IO threads Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Added `zookeeper.snapshot.trust.empty=true` for ZK 3.5 upgrade * Perform producer compression from IO threads Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
* Added `zookeeper.snapshot.trust.empty=true` for ZK 3.5 upgrade * Perform producer compression from IO threads Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
* Added `zookeeper.snapshot.trust.empty=true` for ZK 3.5 upgrade * Perform producer compression from IO threads Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
* Added `zookeeper.snapshot.trust.empty=true` for ZK 3.5 upgrade * Perform producer compression from IO threads Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, all the assembly of batches and compression is done in timer thread. When publishing at high throughput with compression enabled, it's easy that this thread becomes the bottleneck.
Since we're already using IO threads to do decompression of messages in the consumer, we should use IO threads when compressing too.