-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pulsar-io-hdfs2] Add config to create subdirectory from current time #7771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/pulsarbot run-failure-checks |
2 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
sijie
approved these changes
Aug 11, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…apache#7771) ### Motivation Adding a subdirectory associated with current time willmake it easier to process HDFS files in batch. For example, user can create multiple running sink instances with `yyyy-MM-dd-hh` pattern. Then stop all instances at next hour. Eventually, files of the subdirectory will contain all messages consumed during this hour. ### Modifications - Add a `subdirectoryPattern` field to `HdfsSinkConfig` - Update some simple tests for `HdfsSinkConfig` - Update the doc of HDFS2 sink ### Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (docs)
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…apache#7771) ### Motivation Adding a subdirectory associated with current time willmake it easier to process HDFS files in batch. For example, user can create multiple running sink instances with `yyyy-MM-dd-hh` pattern. Then stop all instances at next hour. Eventually, files of the subdirectory will contain all messages consumed during this hour. ### Modifications - Add a `subdirectoryPattern` field to `HdfsSinkConfig` - Update some simple tests for `HdfsSinkConfig` - Update the doc of HDFS2 sink ### Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (docs)
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…apache#7771) ### Motivation Adding a subdirectory associated with current time willmake it easier to process HDFS files in batch. For example, user can create multiple running sink instances with `yyyy-MM-dd-hh` pattern. Then stop all instances at next hour. Eventually, files of the subdirectory will contain all messages consumed during this hour. ### Modifications - Add a `subdirectoryPattern` field to `HdfsSinkConfig` - Update some simple tests for `HdfsSinkConfig` - Update the doc of HDFS2 sink ### Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (docs)
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…apache#7771) ### Motivation Adding a subdirectory associated with current time willmake it easier to process HDFS files in batch. For example, user can create multiple running sink instances with `yyyy-MM-dd-hh` pattern. Then stop all instances at next hour. Eventually, files of the subdirectory will contain all messages consumed during this hour. ### Modifications - Add a `subdirectoryPattern` field to `HdfsSinkConfig` - Update some simple tests for `HdfsSinkConfig` - Update the doc of HDFS2 sink ### Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding a subdirectory associated with current time willmake it easier to process HDFS files in batch.
For example, user can create multiple running sink instances with
yyyy-MM-dd-hh
pattern. Then stop all instances at next hour. Eventually, files of the subdirectory will contain all messages consumed during this hour.Modifications
subdirectoryPattern
field toHdfsSinkConfig
HdfsSinkConfig
Documentation