[Transaction] Support consume transaction messages. #7781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
changed the title
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Aug 9, 2020
| private void read(ConcurrentLinkedQueue<TxnID> transactionQueue, | ||
| int readMessageNum, Object ctx, | ||
| AsyncCallbacks.ReadEntriesCallback readEntriesCallback) { | ||
| final TxnID txnID = transactionQueue.peek(); |
There was a problem hiding this comment.
It's might peek null here.
There was a problem hiding this comment.
Ok, I'll add a check.
Comment on lines
60
to
62
| private void read(ConcurrentLinkedQueue<TxnID> transactionQueue, | ||
| int readMessageNum, Object ctx, | ||
| AsyncCallbacks.ReadEntriesCallback readEntriesCallback) { |
There was a problem hiding this comment.
Is the read txn message count is the size of the transactionQueue ? I did not understand this method, is the transactionQueue only stores the first txn ID? I noticed you have only peek one item from this queue.
There was a problem hiding this comment.
I'll adjust this logic.
gaoran10
force-pushed
the
transaction-consume
branch
from
87cb7dd
to
9f213b7
Compare
|
/pulsarbot run-failure-checks |
gaoran10
force-pushed
the
transaction-consume
branch
from
8bd38d9
to
5007a2a
Compare
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Aug 14, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Master Issue: apache#2664 Fix https://github.com/streamnative/pulsar/issues/1304 ### Motivation Currently, the consumer can't receive transaction messages. ### Modifications Support process the commit marker in the topic partition and fetch transaction messages from TransactionBuffer.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Master Issue: apache#2664 Fix https://github.com/streamnative/pulsar/issues/1304 ### Motivation Currently, the consumer can't receive transaction messages. ### Modifications Support process the commit marker in the topic partition and fetch transaction messages from TransactionBuffer.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Master Issue: apache#2664 Fix https://github.com/streamnative/pulsar/issues/1304 ### Motivation Currently, the consumer can't receive transaction messages. ### Modifications Support process the commit marker in the topic partition and fetch transaction messages from TransactionBuffer.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Master Issue: apache#2664 Fix https://github.com/streamnative/pulsar/issues/1304 ### Motivation Currently, the consumer can't receive transaction messages. ### Modifications Support process the commit marker in the topic partition and fetch transaction messages from TransactionBuffer.
codelipenghui
added
component/transaction
area/transaction
and removed
component/transaction
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #2664
Fix https://github.com/streamnative/pulsar/issues/1304
Motivation
Currently, the consumer can't receive transaction messages.
Modifications
Support process the commit marker in the topic partition and fetch transaction messages from TransactionBuffer.
Verifying this change
This change added tests and can be verified as follows:
org.apache.pulsar.broker.transaction.TransactionConsumeTestDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation