-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return more informative error message when trying to create subscript ion on non-persistent through Rest API or pulsar-admin CLI #7831
Merged
jiazhai
merged 1 commit into
apache:master
from
MarvinCai:create-subscription-non-persistent
Aug 21, 2020
Merged
Return more informative error message when trying to create subscript ion on non-persistent through Rest API or pulsar-admin CLI #7831
jiazhai
merged 1 commit into
apache:master
from
MarvinCai:create-subscription-non-persistent
Aug 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion on non-persistent throug Rest API or pulsar-admin CLI.
codelipenghui
approved these changes
Aug 18, 2020
jiazhai
approved these changes
Aug 21, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…ion on non-persistent throug Rest API or pulsar-admin CLI. (apache#7831) Fixes apache#7397 Motivation When use pulsar-admin to create a subscription on a non-persistent topic, get the server error This change return more informative error message when trying to create subscript ion on non-persistent through Rest API or pulsar-admin CLI. Modifications Currently when creating subscription is called with non-persistent topic service will try to create the subscription which will fail with casting exception when trying to cast NonPersistentSubscription to PersistentSubscription and client will see internal error. Add check if create subscription command is called for a non-persistent topic before actually Verifying this change This change added tests and can be verified as follows: Added unit test Verified with local standalone
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…ion on non-persistent throug Rest API or pulsar-admin CLI. (apache#7831) Fixes apache#7397 Motivation When use pulsar-admin to create a subscription on a non-persistent topic, get the server error This change return more informative error message when trying to create subscript ion on non-persistent through Rest API or pulsar-admin CLI. Modifications Currently when creating subscription is called with non-persistent topic service will try to create the subscription which will fail with casting exception when trying to cast NonPersistentSubscription to PersistentSubscription and client will see internal error. Add check if create subscription command is called for a non-persistent topic before actually Verifying this change This change added tests and can be verified as follows: Added unit test Verified with local standalone
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…ion on non-persistent throug Rest API or pulsar-admin CLI. (apache#7831) Fixes apache#7397 Motivation When use pulsar-admin to create a subscription on a non-persistent topic, get the server error This change return more informative error message when trying to create subscript ion on non-persistent through Rest API or pulsar-admin CLI. Modifications Currently when creating subscription is called with non-persistent topic service will try to create the subscription which will fail with casting exception when trying to cast NonPersistentSubscription to PersistentSubscription and client will see internal error. Add check if create subscription command is called for a non-persistent topic before actually Verifying this change This change added tests and can be verified as follows: Added unit test Verified with local standalone
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…ion on non-persistent throug Rest API or pulsar-admin CLI. (apache#7831) Fixes apache#7397 Motivation When use pulsar-admin to create a subscription on a non-persistent topic, get the server error This change return more informative error message when trying to create subscript ion on non-persistent through Rest API or pulsar-admin CLI. Modifications Currently when creating subscription is called with non-persistent topic service will try to create the subscription which will fail with casting exception when trying to cast NonPersistentSubscription to PersistentSubscription and client will see internal error. Add check if create subscription command is called for a non-persistent topic before actually Verifying this change This change added tests and can be verified as follows: Added unit test Verified with local standalone
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
…ion on non-persistent throug Rest API or pulsar-admin CLI. (#7831) Fixes #7397 Motivation When use pulsar-admin to create a subscription on a non-persistent topic, get the server error This change return more informative error message when trying to create subscript ion on non-persistent through Rest API or pulsar-admin CLI. Modifications Currently when creating subscription is called with non-persistent topic service will try to create the subscription which will fail with casting exception when trying to cast NonPersistentSubscription to PersistentSubscription and client will see internal error. Add check if create subscription command is called for a non-persistent topic before actually Verifying this change This change added tests and can be verified as follows: Added unit test Verified with local standalone (cherry picked from commit 7b60e2d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7397
Motivation
When use pulsar-admin to create a subscription on a non-persistent topic, get the server error
This change return more informative error message when trying to create subscript ion on non-persistent through Rest API or pulsar-admin CLI.
Modifications
Currently when creating subscription is called with non-persistent topic service will try to create the subscription which will fail with casting exception when trying to cast NonPersistentSubscription to PersistentSubscription and client will see internal error.
Add check if create subscription command is called for a non-persistent topic before actually
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation