support message dispatch rate on topic level #7863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
codelipenghui
requested review from
codelipenghui,
sijie,
jiazhai and
merlimat
codelipenghui
added
component/topic-policy
doc-required
|
@MarvinCai @jianyun8023 Please help review this PR, thanks. |
|
/pulsarbot run-failure-checks |
jianyun8023
reviewed
Aug 22, 2020
| @@ -3056,4 +3057,53 @@ protected void internalGetLastMessageId(AsyncResponse asyncResponse, boolean aut | |||
| }); | |||
|
|
|||
| } | |||
|
|
|||
| protected void internalGetDispatchRate(AsyncResponse asyncResponse) { | |||
There was a problem hiding this comment.
It is recommended to return CompletableFuture instead of passing in the parameter AsyncResponse
There was a problem hiding this comment.
I have updated the implement interface, please take a look again. Thanks
MarvinCai
reviewed
Aug 22, 2020
|
|
||
| @Override | ||
| public void unregisterListener(TopicName topicName, TopicPolicyListener<TopicPolicies> listener) { | ||
| listeners.computeIfAbsent(topicName, k -> Lists.newCopyOnWriteArrayList()); |
There was a problem hiding this comment.
wouldn't this remove all listeners for a given topic?
There was a problem hiding this comment.
It should remove the specific listener, and i have updated the code, please take a look again. Thanks
jianyun8023
approved these changes
Aug 23, 2020
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
hangc0276
force-pushed
the
add_message_dispatch_rate
branch
from
b6712de
to
90fe769
Compare
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Aug 28, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Support message dispatch rate on topic level. Based on the system topic function. ### Modifications Support set message dispatch rate on topic level. Support get message dispatch rate on topic level. Support remove message dispatch rate on topic level.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Support message dispatch rate on topic level. Based on the system topic function. ### Modifications Support set message dispatch rate on topic level. Support get message dispatch rate on topic level. Support remove message dispatch rate on topic level.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Support message dispatch rate on topic level. Based on the system topic function. ### Modifications Support set message dispatch rate on topic level. Support get message dispatch rate on topic level. Support remove message dispatch rate on topic level.
jiazhai
pushed a commit
that referenced
this pull request
Sep 9, 2020
Fixes #7863 ### Motivation 1) Topic level policy will be overwritten by namespace level 2) After removing the topic level policy, `DispatchLimiter` does not take effect, the namespace level policy should be used ### Modifications 1）If there is a topic-level policy, it will not be overwritten by the namespace-level policy when the policy is updated 2）When removing topic-level policy, namespace-level policy will be used. If the namespace-level policy does not exist, the broker level will be used ### Verifying this change unit test: TopicPoliciesTest#testPolicyOverwrittenByNamespaceLevel
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
Fixes apache#7863 ### Motivation 1) Topic level policy will be overwritten by namespace level 2) After removing the topic level policy, `DispatchLimiter` does not take effect, the namespace level policy should be used ### Modifications 1）If there is a topic-level policy, it will not be overwritten by the namespace-level policy when the policy is updated 2）When removing topic-level policy, namespace-level policy will be used. If the namespace-level policy does not exist, the broker level will be used ### Verifying this change unit test: TopicPoliciesTest#testPolicyOverwrittenByNamespaceLevel
codelipenghui
pushed a commit
that referenced
this pull request
Feb 5, 2021
### Motivation Maybe CI jobs are failing with OOM in the brokers unit tests. The Surefire worker is configured with 4 processes, each with xmx of 1G. The problem was introduced in #7863 where a static map of listeners was added to an interface. That makes that map to contain all the `PulsarService` instances created during the tests execution and keeping references to everything else. The map should instead be scoped to the specific instance.
codelipenghui
pushed a commit
that referenced
this pull request
Feb 5, 2021
Maybe CI jobs are failing with OOM in the brokers unit tests. The Surefire worker is configured with 4 processes, each with xmx of 1G. The problem was introduced in #7863 where a static map of listeners was added to an interface. That makes that map to contain all the `PulsarService` instances created during the tests execution and keeping references to everything else. The map should instead be scoped to the specific instance. (cherry picked from commit 31ee454)
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
…9486) ### Motivation Maybe CI jobs are failing with OOM in the brokers unit tests. The Surefire worker is configured with 4 processes, each with xmx of 1G. The problem was introduced in apache#7863 where a static map of listeners was added to an interface. That makes that map to contain all the `PulsarService` instances created during the tests execution and keeping references to everything else. The map should instead be scoped to the specific instance.
Anonymitaet
added
doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support message dispatch rate on topic level.
Based on the system topic function.
Modifications
Support set message dispatch rate on topic level.
Support get message dispatch rate on topic level.
Support remove message dispatch rate on topic level.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Documentation
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs / JavaDocs)