Add ability for BatchPushSource to notify errors asynchronously #7865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkukarni
approved these changes
Aug 21, 2020
tuteng
approved these changes
Aug 22, 2020
jerrypeng
added a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Aug 24, 2020
…he#7865) Co-authored-by: Jerry Peng <jerryp@splunk.com>
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…he#7865) Co-authored-by: Jerry Peng <jerryp@splunk.com>
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…he#7865) Co-authored-by: Jerry Peng <jerryp@splunk.com>
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
…he#7865) Co-authored-by: Jerry Peng <jerryp@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, there is not a good way for developers using the BatchPushSource class to notify error in an asynchronous fashion.
Modifications
Add a method called "notifyErrors" for developer to be able to notify of errors at any time or in separate thread