Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compaction threshold for topic level #7881

Conversation

hangc0276
Copy link
Contributor

Fix #7826

Motivation

Support compaction threshold on topic level.
Based on the system topic function.

Modifications

Support set compaction threshold on topic level.
Support get compaction threshold on topic level.
Support remove compaction threshold on topic level.

Verifying this change

This change added tests and can be verified as follows:

  • test set topic compaction threshold
  • test remove topic compaction threshold
  • test get topic topic compaction threshold
  • test disabled topic topic compaction threshold

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes)
  • Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs / JavaDocs)

@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.7.0 milestone Aug 24, 2020
@sijie sijie added component/topic-policy type/feature The PR added a new feature or issue requested a new feature labels Aug 24, 2020
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@hangc0276 hangc0276 force-pushed the add_compaction_threshold_for_topic_level branch from ef4b2c6 to f0fdc9e Compare August 28, 2020 10:57
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@hangc0276 hangc0276 force-pushed the add_compaction_threshold_for_topic_level branch from f0fdc9e to 32729ee Compare August 29, 2020 01:20
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 3ff753c into apache:master Aug 30, 2020
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
Fix apache#7826 

### Motivation
Support compaction threshold on topic level.
Based on the system topic function.

### Modifications
Support set compaction threshold on topic level.
Support get compaction threshold on topic level.
Support remove compaction threshold on topic level.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
Fix apache#7826 

### Motivation
Support compaction threshold on topic level.
Based on the system topic function.

### Modifications
Support set compaction threshold on topic level.
Support get compaction threshold on topic level.
Support remove compaction threshold on topic level.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
Fix apache#7826 

### Motivation
Support compaction threshold on topic level.
Based on the system topic function.

### Modifications
Support set compaction threshold on topic level.
Support get compaction threshold on topic level.
Support remove compaction threshold on topic level.
@codelipenghui codelipenghui mentioned this pull request Sep 9, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Compaction Threshold on topic level
3 participants