Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail the health check request when trying to delete the previous subscription. #7906

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Don't fail the health check request when trying to delete the previous subscription. #7906

merged 1 commit into from
Sep 1, 2020

Conversation

codelipenghui
Copy link
Contributor

Motivation

Don't fail the health check request when trying to delete the previous subscription.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this Aug 26, 2020
@codelipenghui codelipenghui added this to the 2.7.0 milestone Aug 26, 2020
@codelipenghui codelipenghui merged commit 800681a into apache:master Sep 1, 2020
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@codelipenghui
Don't fail the health check request when try to delete previous subsc…
79c00e8 
…ription. (apache#7906)
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@codelipenghui
Don't fail the health check request when try to delete previous subsc…
72e5a6b 
…ription. (apache#7906)
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@codelipenghui
Don't fail the health check request when try to delete previous subsc…
df8d97a 
…ription. (apache#7906)
jiazhai pushed a commit that referenced this pull request Oct 18, 2020
@codelipenghui @jiazhai
Don't fail the health check request when try to delete previous subsc…
49b8c6f 
…ription. (#7906)

(cherry picked from commit 800681a)
@jiazhai
Copy link
Member

jiazhai commented Oct 18, 2020

already cherry-picked into branch-2.6

wolfstudy added a commit that referenced this pull request Oct 30, 2020
@wolfstudy
Revert "Don't fail the health check request when try to delete previo…
6ded699 
…us subscription. (#7906)"

This reverts commit 49b8c6f.
wolfstudy pushed a commit that referenced this pull request Oct 30, 2020
@codelipenghui @wolfstudy
Don't fail the health check request when try to delete previous subsc…
58bcfd6 
…ription. (#7906)

(cherry picked from commit 800681a)
@codelipenghui codelipenghui deleted the penghui/health_check_log branch May 19, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazhai jiazhai jiazhai approved these changes

@sijie sijie Awaiting requested review from sijie

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

Assignees

@codelipenghui codelipenghui

Labels
release/2.6.2
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codelipenghui @jiazhai