[ISSUE 7758] Support set Max Producer on topic level. #7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
|
link #7839 PTAL @zhaijack @codelipenghui |
|
@jianyun8023 please help review this PR |
codelipenghui
added
component/topic-policy
doc-required
# Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesDisableTest.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
|
/pulsarbot run-failure-checks |
jianyun8023
reviewed
Aug 31, 2020
Comment on lines
+2374
to
+2388
| protected void internalGetMaxProducers(AsyncResponse asyncResponse) { | ||
| validateAdminAccessForTenant(namespaceName.getTenant()); | ||
| validatePoliciesReadOnlyAccess(); | ||
| if (topicName.isGlobal()) { | ||
| validateGlobalNamespaceOwnership(namespaceName); | ||
| } | ||
| checkTopicLevelPolicyEnable(); | ||
| Optional<Integer> maxProducers = getTopicPolicies(topicName) | ||
| .map(TopicPolicies::getMaxProducerPerTopic); | ||
| if (!maxProducers.isPresent()) { | ||
| asyncResponse.resume(Response.noContent().build()); | ||
| } else { | ||
| asyncResponse.resume(maxProducers.get()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please return CompletableFuture< Integer > instead of passing in AsyncResponse.
There was a problem hiding this comment.
Or directly return Integer.
There was a problem hiding this comment.
It seems some methods similar to this also need to modify, can we modify it all?
codelipenghui
approved these changes
Sep 1, 2020
# Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesDisableTest.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Link [apache#7758 and master issue [apache#2688 ### Motivation Support set/get/remove maxProducers on a topic level.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Link [apache#7758 and master issue [apache#2688 ### Motivation Support set/get/remove maxProducers on a topic level.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Link [apache#7758 and master issue [apache#2688 ### Motivation Support set/get/remove maxProducers on a topic level.
Anonymitaet
added
doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link #7758 and master issue #2688
Motivation
Support set/get/remove maxProducers on a topic level.
Verifying this change
new unit test added.