Allow specifying state storage url for Source/Sink localrun #7930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
jerrypeng
force-pushed
the
add_source_sink_cli_state_url
branch
from
0000607
to
2dd1c54
Compare
aahmed-se
requested changes
Aug 28, 2020
| @@ -127,6 +127,8 @@ void processArguments() throws Exception { | |||
| @Parameters(commandDescription = "Run a Pulsar IO sink connector locally (rather than deploying it to the Pulsar cluster)") | |||
| protected class LocalSinkRunner extends CreateSink { | |||
|
|
|||
| @Parameter(names = "--state-storage-service-url", description = "The URL for the state storage service (the default is Apache BookKeeper)") | |||
There was a problem hiding this comment.
Why is this using the old naming scheme ?
There was a problem hiding this comment.
@aahmed-se this is the current naming scheme
aahmed-se
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.