support subscribe rate on topic level #7991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
@hangc0276 Would you please help update with latest master? |
Jennifer88huang-zz
requested review from
codelipenghui and
rdhabalia
and removed request for
codelipenghui
|
@hangc0276 thanks for your contribution. There are some conflicting files in this PR, could you please resolve those conflicts? thank you. |
Thanks for your feedback @jennifer88huang @jiazhai . The code has a bug and i am adding more tests and try to fix the bug. I will commit the code soon. |
|
@hangc0276 thank you. |
hangc0276
force-pushed
the
add_subscribe_rate_on_topic_level
branch
from
f1c9545
to
0e623ea
Compare
|
/pulsarbot run-failure-checks |
5 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 21, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
Support set subscribe rate on topic level. Support get subscribe rate on topic level. Support remove subscribe rate on topic level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Support set subscribe rate on topic level.
Support get subscribe rate on topic level.
Support remove subscribe rate on topic level.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Documentation
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs / JavaDocs)